Pinned posts

Wed, 27 Nov 2019 22:12:50 +0200

kostikov@zotum.net

I have added MR in upstream with possible pinned posts implementation.
I decided to use comments_closed value and its processing now work in the way like I think pinned posts should - it autmatically disables comments and likes so pinned post looks not so attractive for spamming or flooding in comments.
Also at this moment there can be only one pinned post but it is not hard to enable multiple pinning.
Will be happy for code review and suggestions from respected Hubzilla developers.

https://framagit.org/hubzilla/core/merge_requests/1792

!Zotlabs|Hubzilla Development

show all 17 comments

Wed, 27 Nov 2019 23:02:54 +0200

El Dorado

mike@z.macgirvin.com

@Max Kostikov That works but I sort of think it a bit awkward because you may wish to close comments on something and not pin it. Just to explain better what I was thinking of, was adding a taxonomy entry to indicate the pinned status, and creating a widget to display these separately without affecting the normal stream or stream queries. The widget would not include comments but provide a link to display the conversation, while the posts themselves could have comments. As a widget you could also collapse the widget and all the pinned posts if you've seen them hundreds of times and want to skip to the new stuff. You can also place it on the sidebar. Anyway it's all up to you because you're doing the work and I'm still just talking about it. I'm just throwing this out for consideration because I think ultimately it's a lot more flexible way of doing this and it probably wouldn't be that difficult to pull off.

Wed, 27 Nov 2019 23:37:34 +0200

Max Kostikov

kostikov@zotum.net

@Mike Macgirvin

That works but I sort of think it a bit awkward because you may wish to close comments on something and not pin it.

Yes, I thought about that but as I see at this moment it seems comments_closed is not used (at least I didn't found how and where it used in current code but I know nothing on future plans where this perhaps will be used).
Your proposal sounds interesting and looks more flexible than this. In this way there can be also pinned posts for streams not only for channel page.

Thu, 28 Nov 2019 00:11:37 +0200

El Dorado

mike@z.macgirvin.com

@Max Kostikov @Mike Macgirvin ⚡ comments_closed is currently used in Zap.

Thu, 28 Nov 2019 00:29:30 +0200

Max Kostikov

kostikov@zotum.net

@Mike Macgirvin Oh, I see now. Because in Hubzilla comments disabling currently works with item_nocomment. In this case will be better do not use comments_closed for this purpose and maybe think about custom item_type usage or something like that.

Thu, 28 Nov 2019 02:59:48 +0200 последнее редактирование: Thu, 28 Nov 2019 02:57:57 +0200

M. Dent

dm42@hub.webgoeslocal.net

It sounds to me like you're over thinking this.

A PConfig variable could handle this nicely - a list of mids that are currently "pinned". That would easily be propagated to channel clones. The widget could then have a variable number of pinned posts to show order by posted date, recent activity (edited) or any number of options. Use a json array and store "order" information right in the PConfig entry if you want. Or include the datestamp of when it was pinned and use usort. Add a menu item in the "cog" menu attached to the item to make for a quick "pin this post".

Alternatively, just use the category system already in place and make the widget just show X number of posts in the specified category. Maybe just show the topmost post and collapse posts 2-X so that only their headlines show. Possibly also allow to have various types of posts displayed (Article, Post, WikiPage, etc) with the title linking to the actual item itself.

Lots of options.

Thu, 28 Nov 2019 09:29:45 +0200

Manuel JF

manuel-jf@hub.volse.no

@Max Kostikov Oh, thank you, Max! This is one of my oldest wishes/petitions. At WP I use this option often. I am happy :-)

Thu, 28 Nov 2019 12:01:20 +0200 последнее редактирование: Thu, 28 Nov 2019 12:16:42 +0200

Max Kostikov

kostikov@zotum.net

@Manuel Thanks Manuel, but it seems in this iteration pinned posts is not ready to arrive to upstream. Current straightforward implementation available for testing on @Zotum as usually but will be removed soon.
I like proposed ideas by @Mike Macgirvin and @M. Dent with separate widged but don't sure when it will appear in Hubzilla. This certainly requires additional researching, coding and testing.

Thu, 28 Nov 2019 12:28:40 +0200

Manuel JF

manuel-jf@hub.volse.no

@Max Kostikov A pity! I already have a pinned post in zotum. Anyway, patience, which is the mother of science ;-)

Thu, 28 Nov 2019 12:35:07 +0200

Manuel JF

manuel-jf@hub.volse.no

That option could also be applied to special posts, such as articles?

Thu, 28 Nov 2019 12:40:47 +0200

Max Kostikov

kostikov@zotum.net

@Manuel ...and you were not alone. This is the good indicator that we certainly need to have pinned posts in Hubzilla. :-)
In any case I have removed this code and returned pinned posts to normal state when they can be commented and receive reactions.

Thu, 28 Nov 2019 12:59:11 +0200

Max Kostikov

kostikov@zotum.net

@M. Dent Thanks for insights. You are right, there are a lot of options we can use.
I think the pinned posts should also be somehow highlighted in the stream (e.g. with pin icon) and the better way to do it is to have attribute in item table. I found already defined ITEM_IS_STICKY type which seems isn't used at this moment or we can define a special one for pinned posts.

Thu, 28 Nov 2019 18:04:15 +0200

Max Kostikov

kostikov@zotum.net

@Manuel Not at this moment. Let's try to start with regular posts and then maybe we can add other content.

Sun, 01 Dec 2019 00:05:13 +0200 последнее редактирование: Sun, 01 Dec 2019 00:08:50 +0200

Max Kostikov

kostikov@zotum.net

I have started testing the new version of pinned posts at @Zotum.
At this moment this available only on channel page and support only one pinned post.
Current implementaion uses own widget to display pinned post, stores related data in pconf, syncs with clones and in theory should support different content types such as events, polls and articles.
Thanks to @Mike Macgirvin and @M. Dent for inputs!

Sun, 01 Dec 2019 00:57:25 +0200

El Dorado

mike@z.macgirvin.com

Thanks for making it happen.

Sun, 01 Dec 2019 16:54:35 +0200 последнее редактирование: Tue, 03 Dec 2019 18:20:03 +0200

Max Kostikov

kostikov@zotum.net

https://framagit.org/hubzilla/core/merge_requests/1794

UPD. Added events / polls support and button for hiding pinned item (should be created 12 h. ago or more).

Wed, 04 Dec 2019 05:32:54 +0200 последнее редактирование: Wed, 04 Dec 2019 05:30:44 +0200

M. Dent

dm42@hub.webgoeslocal.net

I like it! I might suggest also adding the "unpin" to the menu of the pinned item itself if possible. But, it's pretty intuitive. Another thought - if there's already a pinned post, maybe make the menu "Replace pinned post" - at least unless/until multiple pinned posts are an option.

But this is awesome! Thanks for the hard work!

Wed, 04 Dec 2019 10:40:09 +0200

Max Kostikov

kostikov@zotum.net

@M. Dent

suggest also adding the "unpin" to the menu of the pinned item itself

Sure. Also I just realised that I need to add special procedure for unpinning pinned item on administrator deletion.
Will add it shortly.